From f5025dfb39eb5f84fdb3d18d7729d7e1bf16a8d1 Mon Sep 17 00:00:00 2001
From: Zeev Diukman <zeevdukeman@gmail.com>
Date: Sun, 18 Jan 2026 08:41:58 +0200
Subject: [PATCH] test: Add mock-based testing for `z.sh` and refactor its user
 input selection from `select` to `read`.

---
 test_z.sh | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 z.sh      | 31 +++++++++--------
 2 files changed, 117 insertions(+), 13 deletions(-)
 create mode 100644 test_z.sh

diff --git a/test_z.sh b/test_z.sh
new file mode 100644
index 0000000..4957383
--- /dev/null
+++ b/test_z.sh
@@ -0,0 +1,99 @@
+#!/bin/bash
+
+# test_z.sh - Mock testing environment for z.sh
+
+MOCK_DIR=$(mktemp -d)
+MOCK_BIN="$MOCK_DIR/bin"
+mkdir -p "$MOCK_BIN"
+export PATH="$MOCK_BIN:$PATH"
+
+LOG_FILE="$MOCK_DIR/test_log.txt"
+touch "$LOG_FILE"
+
+echo "Using mock directory: $MOCK_DIR"
+
+# Mock lsblk
+cat > "$MOCK_BIN/lsblk" <<'EOF'
+#!/bin/bash
+if [[ "$*" == *"-p -dno NAME,SIZE,MODEL"* ]]; then
+    echo "/dev/vda 100G Mock_Disk"
+    echo "/dev/vdb 50G Mock_Secondary"
+elif [[ "$*" == *"-p -nlo NAME,SIZE,TYPE /dev/vda"* ]]; then
+    echo "/dev/vda1 1G part"
+    echo "/dev/vda2 20G part"
+    echo "/dev/vda3 512M part"
+elif [[ "$*" == *"-p -nlo NAME,SIZE,TYPE /dev/vdb"* ]]; then
+    echo "/dev/vdb1 50G part"
+fi
+EOF
+
+# Mock functions to log calls
+mock_cmd() {
+    local cmd="$1"
+    cat > "$MOCK_BIN/$cmd" <<-EOF
+#!/bin/bash
+echo "[$cmd] \$*" >> "$LOG_FILE"
+EOF
+    chmod +x "$MOCK_BIN/$cmd"
+}
+
+mock_cmd "mkfs.btrfs"
+mock_cmd "mkfs.fat"
+mock_cmd "mount"
+mock_cmd "umount"
+mock_cmd "pacstrap"
+mock_cmd "genfstab"
+mock_cmd "useradd"
+mock_cmd "chpasswd"
+
+# Mock btrfs with logic
+cat > "$MOCK_BIN/btrfs" <<EOF
+#!/bin/bash
+echo "[btrfs] \$*" >> "$LOG_FILE"
+if [[ "\$*" == "subvolume list /mnt" ]]; then
+    # Simulate @ existing
+    echo "ID 256 gen 10 top level 5 path @"
+fi
+EOF
+
+# Mock mountpoint
+cat > "$MOCK_BIN/mountpoint" <<EOF
+#!/bin/bash
+echo "[mountpoint] \$*" >> "$LOG_FILE"
+return 1 # Simulate not mounted
+EOF
+
+# Mock arch-chroot
+cat > "$MOCK_BIN/arch-chroot" <<EOF
+#!/bin/bash
+# Capture stdin if any
+if [[ -p /dev/stdin ]]; then
+    stdin_content=\$(cat)
+    echo "[arch-chroot] stdin: \$stdin_content | cmd: \$*" >> "$LOG_FILE"
+else
+    echo "[arch-chroot] cmd: \$*" >> "$LOG_FILE"
+fi
+EOF
+
+chmod +x "$MOCK_BIN/"*
+
+echo "--- Starting z.sh in Mock Environment ---"
+# Run z.sh and provide sequence of inputs for test scenario 1 (Default settings)
+# Input sequence:
+# 1 (Enter) - Select Disk 1
+# 1 (Enter) - Select Seed
+# 1 (Enter) - Select Sprout
+# 1 (Enter) - Select EFI
+# yes - Confirm formatting
+# (Enter) - Default packages
+# Yes - Confirm installation
+printf "\n\n\n\nyes\n\nYes\n" | bash ./z.sh
+
+echo ""
+echo "--- Test Execution Log ---"
+cat "$LOG_FILE"
+
+# Clean up
+# rm -rf "$MOCK_DIR"
+echo ""
+echo "Logs saved to $LOG_FILE"
diff --git a/z.sh b/z.sh
index 9eb8006..fbf8894 100755
--- a/z.sh
+++ b/z.sh
@@ -15,12 +15,15 @@ if [ ${#disks[@]} -eq 0 ]; then
     exit 1
 fi
 
-PS3="Select a disk to choose partitions from (default 1): "
-select disk_info in "${disks[@]}"; do
-    if [[ -z "$REPLY" ]]; then
-        disk_info="${disks[0]}"
-    fi
-    if [[ -n "$disk_info" ]]; then
+for i in "${!disks[@]}"; do
+    printf "%d) %s\n" "$((i+1))" "${disks[i]}"
+done
+
+while true; do
+    read -r -p "Select a disk to choose partitions from (default 1): " REPLY
+    REPLY=${REPLY:-1}
+    if [[ "$REPLY" -gt 0 && "$REPLY" -le "${#disks[@]}" ]]; then
+        disk_info="${disks[$((REPLY-1))]}"
         selected_disk=$(echo "$disk_info" | awk '{print $1}')
         break
     else
@@ -47,13 +50,15 @@ get_partition() {
 
     echo ""
     echo "$prompt"
-    PS3="$ps3_val (default 1): "
-    local selection
-    select selection in "${parts[@]}"; do
-        if [[ -z "$REPLY" ]]; then
-            selection="${parts[0]}"
-        fi
-        if [[ -n "$selection" ]]; then
+    for i in "${!parts[@]}"; do
+        printf "%d) %s\n" "$((i+1))" "${parts[i]}"
+    done
+
+    while true; do
+        read -r -p "$ps3_val (default 1): " REPLY
+        REPLY=${REPLY:-1}
+        if [[ "$REPLY" -gt 0 && "$REPLY" -le "${#parts[@]}" ]]; then
+            selection="${parts[$((REPLY-1))]}"
             eval "$var_name=$(echo "$selection" | cut -d' ' -f1)"
             break
         else